fix: Correct default export #1269
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an appropriate default export to the package when it is imported (rather than invoked as a CLI command).
@fastly/js-computedoubles as:binentryjs-compute-runtimethat resolves todist/cli/js-compute-runtime-cli.js; and/// <reference types="@fastly/js-compute" />However, since the
mainfield ofpackage.jsonalso pointed to the CLI entry point until now, it was possible to do a nonsensical import in JavaScript code such as:Although the module exports no members, it would still run the side effects (the executable code in the CLI), printing the help message to stdout.
This PR corrects the behavior by adding an empty
index.jsfile that exports nothing and runs no code. It updatespackage.jsonto point the entry point to it usingexportfields (the modern way of defining entry points), and also updates the legacymainfield to point to it as well.